Use ECMGenerateExportHeader to manage deprecated API better
ClosedPublic
Actions

Authored by kossebau on Oct 15 2019, 2:54 PM.

Details

Reviewers

mart
apol

Group Reviewers

Frameworks
Plasma

Commits

R290:d03f2d7114c4: Use ECMGenerateExportHeader to manage deprecated API better

Summary

Allows

projects linking to KPackage to hide deprecated API up to a given version or silence deprecation warnings after a given version, using
- -DKPACKAGE_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKPACKAGE_NO_DEPRECATED
- -DKPACKAGE_DEPRECATED_WARNINGS_SINCE
- -DKPACKAGE_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
to build KPackage optionally with deprecated API excluded from the build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

Test Plan

Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.21.0, CURRENT.

Diff Detail

Repository

R290 KPackage

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau created this revision.Oct 15 2019, 2:54 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptOct 15 2019, 2:54 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.Oct 15 2019, 2:54 PM

Harbormaster completed remote builds in B17719: Diff 67990.Oct 15 2019, 2:54 PM

Given all the KPACKAGE_* macros are public, they should be consistently in the namespace, so for that purpose I also simply changed the BASE_NAME of the export macros.

kossebau mentioned this in T11490: Control for visibility of symbols of deprecated API and compiler warnings.Oct 15 2019, 3:10 PM

keep the current filename of the export header file

Harbormaster completed remote builds in B17720: Diff 67991.Oct 15 2019, 3:18 PM

@apol Hi. Any chance you can give this a review soon, given this is almost the last one remaining before the complete of all (affected) KF modules to ECMGenerateExportHeader is done, and we can enable the respective KF_* macros?

Seems ok for me +1

Reviewed myself once more and will be pushing now, given this is fairly straightforward after all, so the KF_* flags can be enabled next.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 20 2019, 1:05 AM

Closed by commit R290:d03f2d7114c4: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). · Explain Why

This revision was automatically updated to reflect the committed changes.

👍 sorry about slow reviews. The patch looks good.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (4 lines)
M			autotests/plasmoidpackagetest.cpp (6 lines)
M			src/kpackage/CMakeLists.txt (14 lines)
M			src/kpackage/package.h (7 lines)
M			src/kpackage/package.cpp (2 lines)
M			src/kpackage/packageloader.h (2 lines)
M			src/kpackage/packagestructure.h (2 lines)
M			src/kpackage/version.h (12 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	67990	cf8483d		Oct 15 2019, 2:54 PM	★	★
Diff 2	67991	cf8483d	keep the current filename of the export header file	Oct 15 2019, 3:18 PM	★	★
Diff 3	68319	cf8483d	R290:d03f2d7114c40a61b35f3df994b3271748ecfaf5	Oct 20 2019, 1:05 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
17af59cddc05	2e7d1ad4f1c5	cf8483d774dc	Friedrich W. H. Kossebau	Use ECMGenerateExportHeader to manage deprecated API better (Show More…)	Oct 15 2019, 2:54 PM