Differential D24665

Use ECMGenerateExportHeader to manage deprecated API better
ClosedPublic
Actions

Authored by kossebau on Oct 15 2019, 1:55 PM.

Details

Reviewers

dfaure

Group Reviewers

Frameworks

Commits

R243:31f044e50811: Use ECMGenerateExportHeader to manage deprecated API better

Summary

Allows

projects linking to KArchive to hide deprecated API up to a given version or silence deprecation warnings after a given version, using
- -DKARCHIVE_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKARCHIVE_NO_DEPRECATED
- -DKARCHIVE_DEPRECATED_WARNINGS_SINCE
- -DKARCHIVE_NO_DEPRECATED_WARNINGS
  
  or
- -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT
- -DKF_NO_DEPRECATED
- -DKF_DEPRECATED_WARNINGS_SINCE
- -DKF_NO_DEPRECATED_WARNINGS
to build KArchive optionally with deprecated API excluded from the build, using "EXCLUDE_DEPRECATED_BEFORE_AND_AT" cmake argument.

Test Plan

Builds with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to 0, 5.0.0, CURRENT.

Diff Detail

Repository

R243 KArchive

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau created this revision.Oct 15 2019, 1:55 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptOct 15 2019, 1:55 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

Created patch manually here, arc claims:

staging@git.kde.org: Permission denied (publickey).

not yet reached sysadmin to tell what could be the issue.

kossebau mentioned this in T11490: Control for visibility of symbols of deprecated API and compiler warnings.Oct 15 2019, 2:07 PM

As part of the transition to Gitlab, Sysadmin removed the staging repositories which a few Phabricator repositories had been configured to use.

That error can be ignored.

In D24665#547727, @bcooksley wrote:

As part of the transition to Gitlab, Sysadmin removed the staging repositories which a few Phabricator repositories had been configured to use.

That error can be ignored.

It prevented usage of arc though, hard to ignore ;)

I've now removed the Staging Area URI for the KArchive repository, so you should now be able to use Arcanist with it again.

dfaure accepted this revision.Oct 16 2019, 9:03 PM

This revision is now accepted and ready to land.Oct 16 2019, 9:03 PM

Closed by commit R243:31f044e50811: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). · Explain WhyOct 16 2019, 9:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (5 lines)
M			autotests/CMakeLists.txt (1 line)
M			autotests/deprecatedtest.cpp (2 lines)
M			src/CMakeLists.txt (9 lines)
M			src/karchive.h (11 lines)
M			src/kfilterdev.h (14 lines)