Differential D24620

Windows MSVC compile fix
ClosedPublic
Actions

Authored by cullmann on Oct 13 2019, 8:16 PM.

Details

Reviewers
dhaumann
Group Reviewers
Frameworks
Commits
R159:1ea2058a09c9: Windows MSVC compile fix
Summary

This patch is since "long" in craft blueprints, can we merge that?

Test Plan

make && make test

Diff Detail

Repository
R159 KActivities Statistics
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cullmann created this revision.Oct 13 2019, 8:16 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 13 2019, 8:16 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
cullmann requested review of this revision.Oct 13 2019, 8:16 PM
cullmann updated this revision to Diff 67869.

Missed to add file with proper compiler guard :/

cullmann added a comment.Oct 17 2019, 6:37 PM

Ok to push that? Would avoid the last patch in craft to build frameworks.

cullmann added a comment.Oct 20 2019, 6:17 PM

Can I just push that? Then we no longer need to patch just this one framework for Windows.

dhaumann accepted this revision.Oct 20 2019, 7:32 PM
dhaumann added a subscriber: dhaumann.

Imo we should simply try: We have another two weeks for testing.

This revision is now accepted and ready to land.Oct 20 2019, 7:32 PM
Closed by commit R159:1ea2058a09c9: Windows MSVC compile fix (authored by cullmann). · Explain WhyOct 20 2019, 8:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/resultset.h (14 lines)
Msrc/resultset_iterator.cpp (7 lines)
Msrc/utils/lazy_val.h (4 lines)

Diff 68393

View Options

src/resultset.h

Loading...
View Options

src/resultset_iterator.cpp

Loading...
View Options

src/utils/lazy_val.h

Loading...