Differential D24579

Use QString() instead of deprecated QString::null
ClosedPublic
Actions

Authored by kpiwowarski on Oct 12 2019, 12:22 AM.

Tags

None

Subscribers

Details

Reviewers

marten
mlaurent

Commits

R660:4ac982cf916b: Port deprecated QString::null -> QString()

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kpiwowarski requested review of this revision.Oct 12 2019, 12:22 AM

kpiwowarski created this revision.

Harbormaster completed remote builds in B17593: Diff 67759.Oct 12 2019, 12:22 AM

kpiwowarski added a reviewer: marten.Oct 12 2019, 12:25 AM

mlaurent requested changes to this revision.Oct 12 2019, 7:09 AM

mlaurent added a subscriber: mlaurent.

mlaurent added inline comments.

app/galleryhistory.cpp
54	it's not necessary to initialize to QString() when we create QString directly

This revision now requires changes to proceed.Oct 12 2019, 7:09 AM

don't initialize

Harbormaster completed remote builds in B17609: Diff 67786.Oct 12 2019, 12:49 PM

mlaurent accepted this revision.Oct 13 2019, 7:53 AM

This revision is now accepted and ready to land.Oct 13 2019, 7:53 AM

Ping ?

In D24579#554188, @mlaurent wrote:

Ping ?

i don't have commit access

Closed by commit R660:4ac982cf916b: Port deprecated QString::null -> QString() (authored by kpiwowarski, committed by marten). · Explain WhyOct 28 2019, 2:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
A	M		.arcconfig (3 lines)
M			.gitignore (2 lines)
M			app/formatdialog.cpp (2 lines)
M			app/galleryhistory.cpp (4 lines)
M			app/imgprintdialog.cpp (2 lines)
M			app/imgsaver.h (4 lines)
M			app/imgsaver.cpp (40 lines)
M			app/kookaimage.cpp (6 lines)
M			app/kookapref.cpp (10 lines)
M			app/kookaview.cpp (4 lines)
M			app/scangallery.h (2 lines)
M			app/scangallery.cpp (72 lines)
M			app/scanparamsdialog.cpp (4 lines)
M			app/statusbarmanager.cpp (2 lines)
M			libdialogutil/recentsaver.h (4 lines)
M			libfiletree/filetreebranch.cpp (2 lines)
M			libkookascan/autoselectbar.cpp (2 lines)
M			libkookascan/autoselectdialog.cpp (4 lines)
M			libkookascan/kscancontrols.h (2 lines)
M			libkookascan/kscancontrols.cpp (10 lines)
M			libkookascan/kscandevice.h (2 lines)
M			libkookascan/kscanoptset.h (2 lines)
M			libkookascan/kscanoptset.cpp (2 lines)
M			libkookascan/scanparams.cpp (40 lines)
M			libkookascan/scansourcedialog.cpp (2 lines)
M			plugins/ocr/abstractocrdialogue.h (2 lines)
M			plugins/ocr/abstractocrdialogue.cpp (2 lines)
M			plugins/ocr/abstractocrengine.h (4 lines)
M			plugins/ocr/abstractocrengine.cpp (8 lines)
M			plugins/ocr/gocr/ocrgocrdialog.cpp (8 lines)
M			plugins/ocr/gocr/ocrgocrengine.cpp (4 lines)
M			plugins/ocr/kadmos/ocrkadmosdialog.cpp (2 lines)
M			plugins/ocr/kadmos/ocrkadmosengine.cpp (4 lines)
M			plugins/ocr/ocrad/ocrocraddialog.cpp (12 lines)
M			plugins/ocr/ocrad/ocrocradengine.cpp (44 lines)

Diff 68887

.arcconfig

Loading...

.gitignore

Loading...

app/formatdialog.cpp

Loading...

app/galleryhistory.cpp

Loading...

app/imgprintdialog.cpp

Loading...

app/imgsaver.h

Loading...

app/imgsaver.cpp

Loading...

app/kookaimage.cpp

Loading...

app/kookapref.cpp

Loading...

app/kookaview.cpp

Loading...

app/scangallery.h

Loading...

app/scangallery.cpp

Loading...

app/scanparamsdialog.cpp

Loading...

app/statusbarmanager.cpp

Loading...

libdialogutil/recentsaver.h

Loading...

libfiletree/filetreebranch.cpp

Loading...

libkookascan/autoselectbar.cpp

Loading...

libkookascan/autoselectdialog.cpp

Loading...

libkookascan/kscancontrols.h

Loading...

libkookascan/kscancontrols.cpp

Loading...

libkookascan/kscandevice.h

Loading...

libkookascan/kscanoptset.h

Loading...

libkookascan/kscanoptset.cpp

Loading...

libkookascan/scanparams.cpp

Loading...

libkookascan/scansourcedialog.cpp

Loading...

plugins/ocr/abstractocrdialogue.h

Loading...

plugins/ocr/abstractocrdialogue.cpp

Loading...

plugins/ocr/abstractocrengine.h

Loading...

plugins/ocr/abstractocrengine.cpp

Loading...

plugins/ocr/gocr/ocrgocrdialog.cpp

Loading...

plugins/ocr/gocr/ocrgocrengine.cpp

Loading...

plugins/ocr/kadmos/ocrkadmosdialog.cpp

Loading...

plugins/ocr/kadmos/ocrkadmosengine.cpp

Loading...

plugins/ocr/ocrad/ocrocraddialog.cpp

Loading...

plugins/ocr/ocrad/ocrocradengine.cpp

Loading...