Use QString() instead of deprecated QString::null
ClosedPublic
Actions

Authored by kpiwowarski on Oct 12 2019, 12:22 AM.

Details

Reviewers

marten
mlaurent

Commits

Repository

R660 Kooka

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17609
Build 17627: arc lint + arc unit

kpiwowarski requested review of this revision.Oct 12 2019, 12:22 AM

kpiwowarski created this revision.

mlaurent requested changes to this revision.Oct 12 2019, 7:09 AM

mlaurent added a subscriber: mlaurent.

mlaurent added inline comments.

app/galleryhistory.cpp
54	it's not necessary to initialize to QString() when we create QString directly

This revision now requires changes to proceed.Oct 12 2019, 7:09 AM

don't initialize

This revision is now accepted and ready to land.Oct 13 2019, 7:53 AM

Ping ?

In D24579#554188, @mlaurent wrote:

Ping ?

i don't have commit access

This revision was automatically updated to reflect the committed changes.

		Path
A	M	.arcconfig (3 lines)
M		.gitignore (2 lines)
M		app/formatdialog.cpp (2 lines)
M		app/galleryhistory.cpp (4 lines)
M		app/imgprintdialog.cpp (2 lines)
M		app/imgsaver.h (4 lines)
M		app/imgsaver.cpp (6 lines)
M		app/kookaimage.cpp (6 lines)
M		app/kookapref.cpp (6 lines)
M		app/kookaview.cpp (4 lines)
M		app/scangallery.h (2 lines)
M		app/scangallery.cpp (8 lines)
M		app/scanparamsdialog.cpp (4 lines)
M		app/statusbarmanager.cpp (2 lines)
M		libdialogutil/recentsaver.h (4 lines)
M		libfiletree/filetreebranch.cpp (2 lines)
M		libkookascan/autoselectbar.cpp (2 lines)
M		libkookascan/autoselectdialog.cpp (4 lines)
M		libkookascan/kscancontrols.h (2 lines)
M		libkookascan/kscancontrols.cpp (10 lines)
M		libkookascan/kscandevice.h (2 lines)
M		libkookascan/kscanoptset.h (2 lines)
M		libkookascan/kscanoptset.cpp (2 lines)
M		libkookascan/scanparams.cpp (12 lines)
M		libkookascan/scansourcedialog.cpp (2 lines)
M		plugins/ocr/abstractocrdialogue.h (2 lines)
M		plugins/ocr/abstractocrdialogue.cpp (2 lines)
M		plugins/ocr/abstractocrengine.h (4 lines)
M		plugins/ocr/abstractocrengine.cpp (8 lines)
M		plugins/ocr/gocr/ocrgocrdialog.cpp (8 lines)
M		plugins/ocr/gocr/ocrgocrengine.cpp (4 lines)
M		plugins/ocr/kadmos/ocrkadmosdialog.cpp (2 lines)
M		plugins/ocr/kadmos/ocrkadmosengine.cpp (4 lines)
M		plugins/ocr/ocrad/ocrocraddialog.cpp (12 lines)
M		plugins/ocr/ocrad/ocrocradengine.cpp (10 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	67759	ba2f6dc		Oct 12 2019, 12:22 AM	★	★
Diff 2	67786	ba2f6dc	don't initialize	Oct 12 2019, 12:49 PM	★	★
Diff 3	68887	ba2f6dc	R660:4ac982cf916b48232c797d390e2d8ca08a993529	Oct 28 2019, 2:47 PM	★	★