Differential D24559

simplify the url parsing
ClosedPublic
Actions

Authored by sitter on Oct 11 2019, 12:58 PM.

Details

Reviewers
dfaure
apol
Commits
R241:c904cbcb9876: simplify the url parsing
Summary

all urls need to have their ports stripped and text set, so de-duplicate
the shared code out of the conditional branches to prevent bugs from
making changes in one branch but not the other

Test Plan

saving and changing proxy settings continues to work

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Oct 11 2019, 12:58 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 11 2019, 12:58 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Oct 11 2019, 12:58 PM
apol accepted this revision.Oct 11 2019, 11:30 PM
This revision is now accepted and ready to land.Oct 11 2019, 11:30 PM
Closed by commit R241:c904cbcb9876: simplify the url parsing (authored by sitter). · Explain WhyOct 14 2019, 10:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kcms/kio/kproxydlg.cpp (23 lines)

Diff 67881

View Options

src/kcms/kio/kproxydlg.cpp

Loading...