This will keep the code of the following changes simpler to read. It introduces no functional change.
Details
- Reviewers
ngraham - Group Reviewers
Baloo - Commits
- R293:198f82eb511f: [Database] Rework handling environment flags
Diff Detail
- Repository
- R293 Baloo
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
This doesn't apply cleanly on master. Can you rebase it?
Also it would be nice to use arc to submit patches: https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist
This is strange because I rebased it to latest master just before submitting it here. Maybe I used an outdated mirror. Let me check.
Also it would be nice to use arc to submit patches: https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist
Ah, there it is. It isn't in the default Gentoo repository.
Will check back soon.
Rebase and submit with arc
- [Database] Rework handling environment flags
- [Database] Disable read-ahead to prevent thrashing
Now arc squashed all my commits into one single diff... I'm not sure if I like that.
Where's the point in using arc to create a branch when it just squashes all your single commits then?
Also, the diff title is now messed up and doesn't reflect what the diff does.
I'm tempted to abandon this diff and start over.