Differential D24539

[Database] Rework handling environment flags
ClosedPublic
Actions

Authored by hurikhan77 on Oct 10 2019, 5:41 PM.

Details

Reviewers
ngraham
Group Reviewers
Baloo
Commits
R293:198f82eb511f: [Database] Rework handling environment flags
Summary

This will keep the code of the following changes simpler to read. It introduces no functional change.

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hurikhan77 created this revision.Oct 10 2019, 5:41 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 10 2019, 5:41 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
hurikhan77 requested review of this revision.Oct 10 2019, 5:41 PM
ngraham added a comment.Oct 10 2019, 8:03 PM

This doesn't apply cleanly on master. Can you rebase it?

Also it would be nice to use arc to submit patches: https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist

hurikhan77 added a comment.Oct 11 2019, 7:51 AM
In D24539#545019, @ngraham wrote:

This doesn't apply cleanly on master. Can you rebase it?

This is strange because I rebased it to latest master just before submitting it here. Maybe I used an outdated mirror. Let me check.

Also it would be nice to use arc to submit patches: https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist

Ah, there it is. It isn't in the default Gentoo repository.

Will check back soon.

hurikhan77 updated this revision to Diff 67677.Oct 11 2019, 8:22 AM

Rebase and submit with arc

  • [Database] Rework handling environment flags
  • [Database] Disable read-ahead to prevent thrashing
hurikhan77 added a comment.EditedOct 11 2019, 8:27 AM

Now arc squashed all my commits into one single diff... I'm not sure if I like that.

Where's the point in using arc to create a branch when it just squashes all your single commits then?

Also, the diff title is now messed up and doesn't reflect what the diff does.

I'm tempted to abandon this diff and start over.

hurikhan77 updated this revision to Diff 67680.Oct 11 2019, 8:40 AM

Using single-patch-per-branch approach

This feels unnatural... :-\

ngraham accepted this revision.Oct 11 2019, 4:31 PM
This revision is now accepted and ready to land.Oct 11 2019, 4:31 PM
Closed by commit R293:198f82eb511f: [Database] Rework handling environment flags (authored by hurikhan77, committed by ngraham). · Explain WhyOct 11 2019, 4:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/engine/database.cpp (6 lines)

Diff 67723

View Options

src/engine/database.cpp

Loading...