Complete the implementation of Capture tab gain control.
ClosedPublic

Authored by murveit on Tue, Oct 8, 3:44 AM.

Details

Summary

With this change, gain is display the same as ISO would be in the capture job queue table.
Also, gain can be set with either custom properties or the gain spin box,
and they both stay in sync; e.g. setting custom properties sets the gain spin box, and
setting the gain spin box sets the custom properties.

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
murveit created this revision.Tue, Oct 8, 3:44 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptTue, Oct 8, 3:44 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
murveit requested review of this revision.Tue, Oct 8, 3:44 AM
murveit updated this revision to Diff 67477.Tue, Oct 8, 5:39 AM

Added a don't-set-gain value.

Added a "don't set gain" value, that won't set gain if chosen.
I believe this will play better for users with existing sequence queue files.

yurchor added a subscriber: yurchor.Tue, Oct 8, 5:45 AM
yurchor added inline comments.
kstars/ekos/capture/capture.cpp
900

Shouldn't this be 'i18n("--")' instead of 'tr("--"))'?

mutlaqja added inline comments.Tue, Oct 8, 5:54 AM
kstars/ekos/capture/customproperties.cpp
132

shouldn't that be valueChanged() or propertyChanged()?

murveit updated this revision to Diff 67478.Tue, Oct 8, 6:22 AM

small changes: tr --> i18n and slotChanged --> valueChanged

mutlaqja accepted this revision.Tue, Oct 8, 7:09 AM
This revision is now accepted and ready to land.Tue, Oct 8, 7:09 AM
This revision was automatically updated to reflect the committed changes.