Complete the implementation of Capture tab gain control.
ClosedPublic
Actions

Authored by murveit on Oct 8 2019, 3:44 AM.

Details

Reviewers

Commits

R321:a2f50ed3f0d5: Complete the implementation of Capture tab gain control.

Summary

With this change, gain is display the same as ISO would be in the capture job queue table.
Also, gain can be set with either custom properties or the gain spin box,
and they both stay in sync; e.g. setting custom properties sets the gain spin box, and
setting the gain spin box sets the custom properties.

Diff Detail

Repository

R321 KStars

Branch

capture-gain-control (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17430
Build 17448: arc lint + arc unit

murveit created this revision.Oct 8 2019, 3:44 AM

Restricted Application added a project: KDE Edu. · View Herald TranscriptOct 8 2019, 3:44 AM

Restricted Application added a subscriber: kde-edu. · View Herald Transcript

murveit requested review of this revision.Oct 8 2019, 3:44 AM

Harbormaster completed remote builds in B17428: Diff 67476.Oct 8 2019, 3:44 AM

Added a don't-set-gain value.

Added a "don't set gain" value, that won't set gain if chosen.
I believe this will play better for users with existing sequence queue files.

Harbormaster completed remote builds in B17429: Diff 67477.Oct 8 2019, 5:39 AM

yurchor added a subscriber: yurchor.Oct 8 2019, 5:45 AM

yurchor added inline comments.

kstars/ekos/capture/capture.cpp
900	Shouldn't this be 'i18n("--")' instead of 'tr("--"))'?

mutlaqja added inline comments.Oct 8 2019, 5:54 AM

kstars/ekos/capture/customproperties.cpp
132	shouldn't that be valueChanged() or propertyChanged()?

small changes: tr --> i18n and slotChanged --> valueChanged

Harbormaster completed remote builds in B17430: Diff 67478.Oct 8 2019, 6:22 AM

mutlaqja accepted this revision.Oct 8 2019, 7:09 AM

This revision is now accepted and ready to land.Oct 8 2019, 7:09 AM

Closed by commit R321:a2f50ed3f0d5: Complete the implementation of Capture tab gain control. (authored by murveit, committed by mutlaqja). · Explain WhyOct 8 2019, 8:12 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			kstars/ekos/capture/capture.h (1 line)
M			kstars/ekos/capture/capture.cpp (50 lines)
M			kstars/ekos/capture/capture.ui (4 lines)
M			kstars/ekos/capture/customproperties.h (3 lines)
M			kstars/ekos/capture/customproperties.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	67476	d5e7c1b		Oct 8 2019, 3:44 AM	★	★
Diff 2	67477	d5e7c1b	Added a don't-set-gain value.	Oct 8 2019, 5:39 AM	★	★
Diff 3	67478	d5e7c1b	small changes: tr --> i18n and slotChanged --> valueChanged	Oct 8 2019, 6:22 AM	★	★
Diff 4	67479	722159d	R321:a2f50ed3f0d577ebb1f1973bc461d7e672f1a569	Oct 8 2019, 8:11 AM	★	★