ensure winId() not called on non-native widgets
ClosedPublic

Authored by cullmann on Sun, Oct 6, 1:48 PM.

Details

Summary

if we do that, window will be corrupted

BUG: 412675

Test Plan

Use Kate, change color theme on a second screen with scaling

Diff Detail

Repository
R252 Framework Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cullmann created this revision.Sun, Oct 6, 1:48 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSun, Oct 6, 1:48 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
cullmann requested review of this revision.Sun, Oct 6, 1:48 PM
broulik added a subscriber: broulik.Sun, Oct 6, 1:50 PM

Can you also check KRun, I'm sure we've had issues with startup reporting stuff in the past

You mean if there are such calls?
Can do.
Btw., Gwenview doesn't render for me any pictures on the second screen either, but I found there no suspicious code :/

For KRun for me the calls there look properly guarded.

Can I merge this? The effect is quiet "evil" here ;=)

If possible I would like to have this in 5.63, as otherwise any color scheme change will make all Qt applications on the non-primary screen unusable with scaling.

If nobody objects will push that later, without any window on secondary screen is garbage after palette change.

dfaure accepted this revision.Mon, Oct 7, 3:57 PM

Looks good, quite similar to https://phabricator.kde.org/D23808

This revision is now accepted and ready to land.Mon, Oct 7, 3:57 PM

It would be great to have that in 5.63, or I am too late?

This revision was automatically updated to reflect the committed changes.
dfaure added a comment.Mon, Oct 7, 8:44 PM

Done, this is in the v5.63.0-rc3 tag now.