Small performance improvements suggested by clang-tidy
ClosedPublic
Actions

Authored by aacid on Oct 3 2019, 9:55 PM.

Details

Reviewers

cullmann
dhaumann

Commits

R39:8930c48f7e08: Small performance improvements suggested by clang-tidy

Summary

As far as i can see none of the modified .h files is actually public so
that shouldn't be a BC problem

Diff Detail

Repository

R39 KTextEditor

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 17310
Build 17328: arc lint + arc unit

aacid created this revision.Oct 3 2019, 9:55 PM

Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptOct 3 2019, 9:55 PM

Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript

aacid requested review of this revision.Oct 3 2019, 9:55 PM

Harbormaster completed remote builds in B17310: Diff 67288.Oct 3 2019, 9:55 PM

aacid planned changes to this revision.Oct 4 2019, 8:30 AM

aacid added inline comments.

src/vimode/modes/modebase.cpp
333	This is wrong, QRegExp is broken and lastIndexIn modifies the object even if the function is marked as const

I think this is ok to merge, I don't see the issue with the QRegExp. (I understand that it stores it result in mutable data in the object, but that patch didn't alter this, just avoids the copying of the regex before this happens, or do I misread the diff?)

src/vimode/modes/modebase.cpp
333	Hmm, given that is a local var on the stack, I don't see an issue with this. This would only be problematic with some static var, or?

I also think it's fine. A next patch could convert the QRegExp to a QRegularExpression.

Ok, i'll commit it then :)

src/vimode/modes/modebase.cpp
333	right is a local var ^_^ i got confused by a similar-ish patch in qtbase where the qregexp was passed in.

This revision is now accepted and ready to land.Oct 4 2019, 9:49 PM

aacid closed this revision.Oct 4 2019, 9:56 PM

Revision Contents
Changeset List

			Path	Packages
M			src/completion/expandingtree/expandingwidgetmodel.cpp (2 lines)
M			src/completion/katecompletionmodel.h (2 lines)
M			src/completion/katecompletionmodel.cpp (2 lines)
M			src/completion/katecompletionwidget.cpp (4 lines)
M			src/document/editorconfig.cpp (2 lines)
M			src/document/katedocument.h (8 lines)
M			src/document/katedocument.cpp (8 lines)
M			src/render/katerenderrange.cpp (2 lines)
M			src/render/katetextlayout.cpp (2 lines)
M			src/schema/katestyletreewidget.cpp (12 lines)
M			src/script/katecommandlinescript.h (2 lines)
M			src/script/katecommandlinescript.cpp (2 lines)
M			src/search/katesearchbar.cpp (2 lines)
M			src/utils/attribute.cpp (2 lines)
M			src/utils/katecmd.cpp (2 lines)
M			src/utils/kateglobal.cpp (2 lines)
M			src/utils/variable.cpp (2 lines)
M			src/view/katemessagewidget.cpp (2 lines)
M			src/view/katestatusbar.cpp (2 lines)
M			src/view/katetextanimation.cpp (2 lines)
M			src/view/kateview.cpp (2 lines)
M			src/view/kateviewinternal.cpp (4 lines)
M			src/vimode/command.h (2 lines)
M			src/vimode/command.cpp (2 lines)
M			src/vimode/modes/modebase.h (2 lines)
M			src/vimode/modes/modebase.cpp (8 lines)

Commit	Tree	Parents	Author	Summary	Date
e47106fc03ae	b39f79f51f08	14c72faa0820	Albert Astals Cid	Small performance improvements suggested by clang-tidy (Show More…)	Oct 3 2019, 9:54 PM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	67288	14c72fa		Oct 3 2019, 9:55 PM	★	★

Small performance improvements suggested by clang-tidyClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 67288

src/completion/expandingtree/expandingwidgetmodel.cpp

src/completion/katecompletionmodel.h

src/completion/katecompletionmodel.cpp

src/completion/katecompletionwidget.cpp

src/document/editorconfig.cpp

src/document/katedocument.h

src/document/katedocument.cpp

src/render/katerenderrange.cpp

src/render/katetextlayout.cpp

src/schema/katestyletreewidget.cpp

src/script/katecommandlinescript.h

src/script/katecommandlinescript.cpp

src/search/katesearchbar.cpp

src/utils/attribute.cpp

src/utils/katecmd.cpp

src/utils/kateglobal.cpp

src/utils/variable.cpp

src/view/katemessagewidget.cpp

src/view/katestatusbar.cpp

src/view/katetextanimation.cpp

src/view/kateview.cpp

src/view/kateviewinternal.cpp

src/vimode/command.h

src/vimode/command.cpp

src/vimode/modes/modebase.h

src/vimode/modes/modebase.cpp

Small performance improvements suggested by clang-tidy
ClosedPublic
Actions

Revision Contents
Changeset List