typically we pass the param as const &, but here we forgot, we can fix
that problem by adding an std::move and have a very similar effect to if
we had declared the params as const &
Details
Details
- Reviewers
leinir - Commits
- R235:1c8d9beb720f: Add some std::move in setter functions
Diff Detail
Diff Detail
- Repository
- R235 Attica
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks good :) If you could pop in a TODO KF6 comment, so it's not forgotten when we can, in fact, fix it properly, that'd be great :)