Make 22px squiggle more like 16px squiggle
ClosedPublic

Authored by ndavis on Sep 26 2019, 9:27 PM.

Details

Test Plan

Old


New

Diff Detail

Repository
R266 Breeze Icons
Branch
squiggle (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 17076
Build 17094: arc lint + arc unit
ndavis created this revision.Sep 26 2019, 9:27 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 26 2019, 9:27 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Sep 26 2019, 9:27 PM
ndavis edited the test plan for this revision. (Show Details)Sep 26 2019, 9:30 PM
ndavis edited the test plan for this revision. (Show Details)

Visually I think this is fine and a good improvement.

I wonder why your SVGs have two seperate paths as opposed to unifying them into one path (as I usually do)? Just curious if there is any benefit to using one approach above the other.
Also, judging by the MDN Page I don't think the fill-rule="evenodd" does anything here.

Visually I think this is fine and a good improvement.

I wonder why your SVGs have two seperate paths as opposed to unifying them into one path (as I usually do)? Just curious if there is any benefit to using one approach above the other.
Also, judging by the MDN Page I don't think the fill-rule="evenodd" does anything here.

Sometimes the optimizers prefer to group rather than combine. These days, optimization is used to keep diffs readable so I can find mistakes and to cut down the size most of the way. Optimizing down to the last byte we can get rid of is not necessary.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 1 2019, 5:22 PM
This revision was automatically updated to reflect the committed changes.