The code compiles and passes all unit tests
Details
Details
- Reviewers
dfaure - Group Reviewers
Frameworks - Commits
- R241:ffb666d46a4a: [src/ioslaves/*] replace deprecated foreach with range for
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Branch
- ahmad/foreach-ioslaves2 (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 17052 Build 17070: arc lint + arc unit
src/ioslaves/http/http.cpp | ||
---|---|---|
2612 ↗ | (On Diff #66815) | need to move that function call into a const local variable |
src/ioslaves/http/httpauthentication.cpp | ||
548 ↗ | (On Diff #66815) | same here |
src/ioslaves/http/kcookiejar/kcookiejar.cpp | ||
348 ↗ | (On Diff #66815) | [that one actually returns a reference so it's actually fine.... until someone changes that...] |
1413 ↗ | (On Diff #66815) | Keeps the separate variable, make it const. Otherwise this will detach. |
src/ioslaves/http/kcookiejar/kcookieserver.cpp | ||
392 ↗ | (On Diff #66815) | [ok, returns a ref] |
src/ioslaves/trash/trashimpl.cpp | ||
717 ↗ | (On Diff #66815) | needs local var |
src/ioslaves/http/http.cpp | ||
---|---|---|
2612 ↗ | (On Diff #66815) | Right. A temporary; but since it's a qstringlist it's implicitly shared. |
src/ioslaves/http/http.cpp | ||
---|---|---|
2612 ↗ | (On Diff #66815) | Yes it is, so non-const begin() will detach and make a full copy. |