[Cursor KCM] Restore live preview on hover
ClosedPublic

Authored by broulik on Sep 23 2019, 1:01 PM.

Details

Summary

When hovering a cursor in the delegate, it changes the mouse cursor to it.
While at it, modernize, i.e. nullptr, range-for, KWindowSystem::isPlatformX11(), coding style

Test Plan
  • Moved my mouse through the delegates, got a live cursor for all the cursors and all the themes

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 23 2019, 1:01 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 23 2019, 1:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 23 2019, 1:01 PM

Nice. While you're at it, can you make the preview be more like the icon theme previews and automatically scroll vertically rather than getting cut off when content doesn't entirely fit in the frame?

when content doesn't entirely fit in the frame?

How can that happen with the small number of previews?

when content doesn't entirely fit in the frame?

How can that happen with the small number of previews?

Like this:

When you increase the cursor size, the size of the cursors in the preview increases as well, resulting in this:

Maybe the delegates need to be a bit bigger and the items in the preview shouldn't change in size if you increase the cursor size? The size combo box already has an inline preview in it anyway.

davidedmundson accepted this revision.Sep 23 2019, 2:17 PM
This revision is now accepted and ready to land.Sep 23 2019, 2:17 PM
This revision was automatically updated to reflect the committed changes.