Replace kaccounts KCM with the one from plasma mobile
ClosedPublic
Actions

Authored by nicolasfella on Sep 21 2019, 12:14 PM.

Details

Reviewers

bshah
dvratil
ognarb

Group Reviewers

Plasma

Commits

R155:feb0b036da1c: Replace kaccounts KCM with the one from plasma mobile

Summary

plasma-settings has a QML version of the accounts KCM. Since there's no point in using a separate KCM for dekstop and mobile use it on the desktop as well. Code is a almost direct copy from plasma-settings

Test Plan

Opened KCM. Added a google account

Diff Detail

Repository

R155 KAccounts Integration

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella requested review of this revision.Sep 21 2019, 12:14 PM

nicolasfella created this revision.

Harbormaster completed remote builds in B16866: Diff 66585.Sep 21 2019, 12:14 PM

nicolasfella edited the summary of this revision. (Show Details)Sep 21 2019, 12:19 PM

nicolasfella edited the test plan for this revision. (Show Details)

nicolasfella added reviewers: Plasma, bshah, dvratil.

nicolasfella edited the summary of this revision. (Show Details)

Looks good to me.

src/kcm/package/metadata.desktop
71	Add deaktop here please.

This revision is now accepted and ready to land.Sep 23 2019, 6:16 AM

ognarb accepted this revision.Sep 23 2019, 8:03 AM

ognarb added a subscriber: ognarb.

ognarb added inline comments.

src/kcm/accounts.h
36	`= default;`

Closed by commit R155:feb0b036da1c: Replace kaccounts KCM with the one from plasma mobile (authored by nicolasfella). · Explain WhySep 23 2019, 8:59 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/CMakeLists.txt (31 lines)
D	M	src/accountwidget.h (54 lines)
D	M	src/accountwidget.cpp (177 lines)
D	M	src/create.h (60 lines)
D	M	src/create.cpp (161 lines)
M		src/declarative/CMakeLists.txt (2 lines)
D	M	src/kaccounts.h (58 lines)
D	M	src/kaccounts.cpp (148 lines)
D	M	src/kcm.ui (94 lines)
A	M	src/kcm/CMakeLists.txt (18 lines)
A	M	src/kcm/accounts.h (38 lines)
A	M	src/kcm/accounts.cpp (38 lines)
V		src/{kcm ← }/kcm_kaccounts.desktop
A	M	src/kcm/package/contents/ui/Accounts.qml (77 lines)
A	M	src/kcm/package/contents/ui/AvailableAccounts.qml (55 lines)
A	M	src/kcm/package/contents/ui/AvailableServices.qml (47 lines)
A	M	src/kcm/package/metadata.desktop (71 lines)
V		src/{ → kcm}/kcm_kaccounts.desktop
V		src/{lib ← }/uipluginsmanager.h
V		src/{lib ← }/uipluginsmanager.cpp
D	M	src/models/accountsmodel.h (53 lines)
D	M	src/models/accountsmodel.cpp (230 lines)
D	M	src/services.ui (85 lines)
D	M	src/types.ui (99 lines)
V		src/{ → lib}/uipluginsmanager.h
V		src/{ → lib}/uipluginsmanager.cpp