Select also raw button press/release in XInput2 based polling
ClosedPublic
Actions

Authored by graesslin on Aug 11 2016, 10:59 AM.

Details

Reviewers

Group Reviewers

Plasma
KWin

Commits

R108:71c996fe33d0: Select also raw button press/release in XInput2 based polling

Summary

The mouse polling is also used to detect mouse button press/release
events. This is used e.g. by the MouseClickEffect. The XInput2 filter
only selected for Raw Motion events which means mouse button events
are missed in case it's not combined with a motion.

This change makes the input filter also select for raw button press
and release events. To support this the X11EventFilter needed to
be adjusted to support multiple generic event types to filter for.

BUG: 366612
FIXED-IN: 5.7.4

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 5828.Aug 11 2016, 10:59 AM

graesslin retitled this revision from to Select also raw button press/release in XInput2 based polling.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma.

Restricted Application added a project: KWin. · View Herald TranscriptAug 11 2016, 10:59 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

broulik added a subscriber: broulik.Aug 11 2016, 1:32 PM

broulik added inline comments.

x11eventfilter.h
40	const-ref

graesslin marked an inline comment as done.Aug 11 2016, 2:47 PM

const-ref

graesslin added a dependent revision: D2425: Support modifier only shortcuts on X11.Aug 12 2016, 1:28 PM

mart accepted this revision.Aug 15 2016, 1:50 PM

mart added a reviewer: mart.

This revision is now accepted and ready to land.Aug 15 2016, 1:50 PM

Closed by commit R108:71c996fe33d0: Select also raw button press/release in XInput2 based polling (authored by graesslin). · Explain WhyAug 15 2016, 2:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/test_xrandr_screens.cpp (2 lines)
M			cursor.cpp (4 lines)
M			events.cpp (2 lines)
M			x11eventfilter.h (9 lines)
M			x11eventfilter.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5828	921e272		Aug 11 2016, 10:59 AM	★	★
Diff 2	5836	921e272	const-ref	Aug 11 2016, 2:47 PM	★	★
Diff 3	5935	81d0454	rKWIN71c996fe33d0b4032c0e71293a1c283d69b9c2f8	Aug 15 2016, 2:06 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
3e0740733ee5	eefa7874f8e9	921e27257cf1	Martin Gräßlin	Select also raw button press/release in XInput2 based polling (Show More…)	Aug 11 2016, 10:55 AM

	Status	Author	Revision
	Closed	graesslin	D2425 Support modifier only shortcuts on X11
	Closed	graesslin	D2406 Select also raw button press/release in XInput2 based polling

Diff 5935

View Options

autotests/test_xrandr_screens.cpp

View Options

cursor.cpp

View Options

events.cpp

View Options

x11eventfilter.h

View Options

Select also raw button press/release in XInput2 based pollingClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 5935

autotests/test_xrandr_screens.cpp

cursor.cpp

events.cpp

x11eventfilter.h

x11eventfilter.cpp

Select also raw button press/release in XInput2 based polling
ClosedPublic
Actions

Revision Contents
Changeset List