Bundle plugin files on Android
ClosedPublic
Actions

Authored by nicolasfella on Sep 17 2019, 2:33 PM.

Details

Reviewers

apol
vkrause

Commits

R307:2ce4d6164797: Bundle plugin files on Android

Summary

We need to tell androiddeployqt to include the plugins into the APK

Test Plan

Build plasma-phonebook with KPeopleVCard installed. KPeopleVCard and the plasma-phonebook action plugin show up in the APK

Repository

R307 KPeople

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

nicolasfella requested review of this revision.Sep 17 2019, 2:33 PM

This revision is now accepted and ready to land.Sep 17 2019, 2:35 PM

vkrause requested changes to this revision.Sep 17 2019, 2:39 PM

This revision now requires changes to proceed.Sep 17 2019, 2:39 PM

This revision was not accepted when it landed; it landed in state Needs Revision.Sep 17 2019, 2:39 PM

This revision was automatically updated to reflect the committed changes.

sorry, I somehow keep misclicking the approve button, was meant to +2 this too of course

			Path	Packages
M			src/CMakeLists.txt (4 lines)
A	M		src/KF5People-android-dependencies.xml (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	66297			Sep 17 2019, 2:31 PM	★	★
Diff 2	66299	3709071	R307:2ce4d61647972c61100ae0dbd06c328d9d9901da	Sep 17 2019, 2:36 PM	★	★