Differential D24020

Support NetworkManager 1.20 and do actually compile the NM backend
ClosedPublic
Actions

Authored by arojas on Sep 17 2019, 9:16 AM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Commits
R239:ec475441f61e: Support NetworkManager 1.20 and do actually compile the NM backend
Summary

NetworkManager.pc and libnm-util.pc are no longer available in 1.20. The only header that kdelibs4support is using is NetworkManager.h, which is found in the include path of libnm.

This actually never worked, since the code was guarded by a never defined if(NM_0_7)

Test Plan

Builds, cmake reports NM is found. Don't know how to test if the backend works.

Diff Detail

Repository
R239 KDELibs4Support
Lint
Lint Skipped
Unit
Unit Tests Skipped
arojas created this revision.Sep 17 2019, 9:16 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 17 2019, 9:16 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
arojas requested review of this revision.Sep 17 2019, 9:16 AM
arojas added a comment.Sep 17 2019, 9:26 AM

Actually I don't think this ever worked - the NM include is guarded by an if(NM_0_7), and this is not defined anywhere

arojas added a comment.Sep 17 2019, 9:44 AM

Indeed, after removing the NM_0_7 check this doesn't even compile...

arojas updated this revision to Diff 66288.Sep 17 2019, 9:45 AM
arojas retitled this revision from Support NetworkManager 1.20 to Support NetworkManager 1.20 and do actually compile the NM backend.
arojas edited the summary of this revision. (Show Details)
dfaure accepted this revision.Sep 22 2019, 12:18 AM
This revision is now accepted and ready to land.Sep 22 2019, 12:18 AM
Closed by commit R239:ec475441f61e: Support NetworkManager 1.20 and do actually compile the NM backend (authored by arojas). · Explain WhySep 22 2019, 2:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 66288

View Options

cmake/modules/FindNetworkManager.cmake

Loading...
View Options

src/solid-networkstatus/kded/CMakeLists.txt

Loading...
View Options

src/solid-networkstatus/kded/networkmanagerstatus.h

Loading...