Differential D24000

Drop effectively unused kemoticons support
ClosedPublic
Actions

Authored by davidedmundson on Sep 16 2019, 5:19 PM.

Details

Reviewers

hein

Maniphest Tasks

T11585: Investigate deprecating KEmoticons in favor of Unicode Emojis

Commits

R7:271da4bd1e58: Drop effectively unused kemoticons support

Summary

Konversation only supported emoticons if config value EnableEmotIcons
was true. This by default was false and there is no UI for configuring
this, making it effectively unused.

This appears to be deliberate from the code comments.

This helps clear up some KEmoticon library usage for future KF6
transitioning.

UTF-8 emoticons work correctly.

Test Plan

Compiles

Diff Detail

Repository

R7 Konversation

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

davidedmundson requested review of this revision.Sep 16 2019, 5:19 PM

davidedmundson created this revision.

Harbormaster completed remote builds in B16640: Diff 66243.Sep 16 2019, 5:19 PM

davidedmundson added a task: T11585: Investigate deprecating KEmoticons in favor of Unicode Emojis.Sep 16 2019, 5:19 PM

vkrause added a reviewer: hein.Nov 26 2019, 5:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Nov 26 2019, 6:06 PM

Closed by commit R7:271da4bd1e58: Drop effectively unused kemoticons support (authored by davidedmundson). · Explain Why

This revision was automatically updated to reflect the committed changes.

(Acked by Eike IRL)

Revision Contents
Changeset List

		Path
M		src/CMakeLists.txt (2 lines)
M		src/config/konversation.kcfg (8 lines)
D	M	src/viewer/emoticons.h (41 lines)
D	M	src/viewer/emoticons.cpp (45 lines)
M		src/viewer/ircview.cpp (3 lines)