| mart |
| Plasma |
Implements the new SDDM theme.
There's a lot of hardcoded values, but the mockup asks for it.
It also doesn't match the mockup exactly because all grid unit sizes are just wrong and partly because in many cases I opted for just using the
Plasma default.
Code is written with the intention to easily port the lock screen
All SDDM related code is now shifted into Main with Login.qml acting as
an abstraction layer.
Ran it, against the awesome mock data.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Shouldn't we be keeping the old theme for nostalgia and such? It's a theme after all.
Maybe, but this patch is against the SDDM theme that was nearly in 5.7, the old theme was already deleted.
It can be restored, but it's a bit irrelevant wrt to this patch.
Screenshot as requested.
Note the coloured icons for actions will be changing when Andreas pushes some change.
Also I have some unresolved comments here: https://phabricator.kde.org/M58/178/
but also working QML code, that means, it must be maintained. if there are volunteers, awesome, if it stays there bitrotting, hmm, not so much
Screenshot as requested.
Note the coloured icons for actions will be changing when Andreas pushes some change.
Also I have some unresolved comments here: https://phabricator.kde.org/M58/178/
what about white circles?
| sddm-theme/KeyboardButton.qml | ||
|---|---|---|
| 13 ↗ | (On Diff #5818) | is this domain valid for sddm as well? |
| sddm-theme/UserDelegate.qml | ||
| 85 ↗ | (On Diff #5818) | this version you have is probably is significantly faster (and in this case i'll shut up :p) but wouldn't look cleaner to have something along the lines: layer.enabled: true layer.effect: OpacityMask {
maskSource: Rectangle {
anchors.centerIn: parent
width: imageWrapper.width
height: width
radius: width/2
}
} |
| sddm-theme/KeyboardButton.qml | ||
|---|---|---|
| 13 ↗ | (On Diff #5818) | It was...though that broke when this folder was moved. Good spot. |
| sddm-theme/UserDelegate.qml | ||
| 85 ↗ | (On Diff #5818) | It's a bit more complex with the white frame that has to be transparent on the inside. So that then needs to be drawn somehow. I guess making an SVG of a circle would work. |
| sddm-theme/KeyboardButton.qml | ||
|---|---|---|
| 13 ↗ | (On Diff #5818) | I wonder if it ever worked to translate those in SDDM? Given KDeclarative takes care of loading translation domain IIRC. |
| sddm-theme/UserDelegate.qml | ||
|---|---|---|
| 85 ↗ | (On Diff #5818) | Using layers opacity mask, the white circle wouldn't be drawn, it's only used to cut a circle out of the user avatar. For the border, could be another rectangle rounded to a circle, which only the border is drawn? |
| sddm-theme/KeyboardButton.qml | ||
|---|---|---|
| 13 ↗ | (On Diff #5818) | It used to work. This has been fixed by 0ece53786e1a7ee37f4ce5e01172673b43a1407c in plasma-workspace master. No changes to this patch are needed. |
to me is ok (if is good design-wise for vdg) my only comment is wether is possible to make the faces avoiding the custom shader, but is not super important