Differential D23980

[Folder View] Don't explicitly initialize fontMetrics
ClosedPublic
Actions

Authored by broulik on Sep 16 2019, 7:20 AM.

Details

Reviewers
hein
apol
ngraham
Group Reviewers
Plasma
Commits
R119:eb9c5f32edbc: [Folder View] Don't explicitly initialize fontMetrics
Summary

qApp->fontMetrics() calls desktop() which creates a QDesktopWidget and might do so on a non-main thread in case of threaded rendering.

BUG: 411953
FIXED-IN: 5.12.10

Test Plan
  • Verified that the default-initialized opt.fontMetrics matches the qApp->fontMetrics()
  • Rubber band still looks normal

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 16 2019, 7:20 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 16 2019, 7:20 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Sep 16 2019, 7:20 AM
apol accepted this revision.Sep 16 2019, 10:02 AM
This revision is now accepted and ready to land.Sep 16 2019, 10:02 AM
ngraham accepted this revision.Sep 16 2019, 2:30 PM
ngraham added a subscriber: ngraham.

Oh boy, wow.

hein accepted this revision.Sep 18 2019, 7:19 AM
Closed by commit R119:eb9c5f32edbc: [Folder View] Don't explicitly initialize fontMetrics (authored by broulik). · Explain WhySep 18 2019, 7:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 66356

View Options

containments/desktop/plugins/folder/rubberband.cpp

Loading...