Differential D23978

Make Desktop Effects KCM desktop file consistent
ClosedPublic
Actions

Authored by GB_2 on Sep 15 2019, 10:02 PM.

Details

Reviewers
zzag
Group Reviewers
KWin
Plasma
VDG
Commits
R108:fba443c49d90: Make Desktop Effects KCM desktop file consistent
Summary

Test Plan

Hover over the Desktop Effects KCM in the system settings sidebar.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
GB_2 created this revision.Sep 15 2019, 10:02 PM
Restricted Application added a project: KWin. · View Herald TranscriptSep 15 2019, 10:02 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
GB_2 requested review of this revision.Sep 15 2019, 10:02 PM
zzag accepted this revision.Sep 15 2019, 10:03 PM
This revision is now accepted and ready to land.Sep 15 2019, 10:03 PM
Closed by commit R108:fba443c49d90: Make Desktop Effects KCM desktop file consistent (authored by GB_2). · Explain WhySep 15 2019, 10:04 PM
This revision was automatically updated to reflect the committed changes.
zzag added a comment.Sep 15 2019, 10:05 PM

I think you should have waited for another +1 from vdg.

GB_2 added a comment.Sep 15 2019, 10:06 PM
In D23978#532198, @zzag wrote:

I think you should have waited for another +1 from vdg.

This is what Nate did in the other patch, without name change.

zzag added a comment.Sep 15 2019, 10:06 PM

Oh nvm then.

ngraham added a subscriber: ngraham.Sep 15 2019, 11:54 PM

Retroactive +1. :)

Revision Contents
Changeset List

Diff 66174

View Options

kcmkwin/kwineffects/kcm.cpp

Loading...
View Options

kcmkwin/kwineffects/kcm_kwin_effects.desktop

Loading...