Differential D23968

Use app specific location for DB on Android
AbandonedPublic
Actions

Authored by nicolasfella on Sep 15 2019, 3:36 PM.

Details

Reviewers
apol
Summary

GenericDataLocation is typically not trivially writable on Android. Since we don't share the database with other apps we can use an app specific directory

Diff Detail

Repository
R307 KPeople
Branch
appdata
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16584
Build 16602: arc lint + arc unit
nicolasfella created this revision.Sep 15 2019, 3:36 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 15 2019, 3:36 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Sep 15 2019, 3:36 PM
apol added a comment.EditedSep 15 2019, 11:15 PM

Then maybe Qt shouldn't offer it? It's supposed to be writable after all...

nicolasfella added a comment.Sep 16 2019, 6:33 AM

I thought the same thing, but I'm not sure if changing that could break some apps

apol added a comment.Sep 16 2019, 10:00 AM
In D23968#532237, @nicolasfella wrote:

I thought the same thing, but I'm not sure if changing that could break some apps

I don't see how many apps would be using a writtableLocation they can't write into. :/

nicolasfella added a comment.Sep 17 2019, 8:49 PM

Turns out GenricDataLocation is probably writeable if the app has WRITE_EXTERNAL_STORAGE permission. In general this makes sense, but in my use case (plasma-phonebook) I'd prefer to have the database in the app-local storage and not request file system access from the user.

nicolasfella abandoned this revision.May 18 2020, 3:52 PM

Revision Contents
Changeset List

PathPackages
Msrc/personmanager.cpp (7 lines)

Diff 66129

View Options

src/personmanager.cpp

Loading...