[KTextEditor] Port away from deprecated QModelIndex::child()
ClosedPublic
Actions

Authored by dfaure on Sep 15 2019, 12:59 PM.

Details

Reviewers

cullmann
dhaumann

Commits

R39:c66c1ec069e5: [KTextEditor] Port away from deprecated QModelIndex::child()

Summary

A bit more verbose in some places, but actually simpler in code
that was checking parent.isValid() and calling index or child, while index does it all.

Test Plan

Compiles

Diff Detail

Repository

R39 KTextEditor

Branch

port_child

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16574
Build 16592: arc lint + arc unit

dfaure created this revision.Sep 15 2019, 12:59 PM

Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSep 15 2019, 12:59 PM

Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript

dfaure requested review of this revision.Sep 15 2019, 12:59 PM

Harbormaster completed remote builds in B16574: Diff 66117.Sep 15 2019, 12:59 PM

Thanks for taking care, I was always to lazy too tackle that :/

This revision is now accepted and ready to land.Sep 15 2019, 1:23 PM

-DQT_DISABLE_DEPRECATED_BEFORE=0x060000 leaves me no choice ;-)

dfaure closed this revision.Sep 15 2019, 1:50 PM

Revision Contents
Changeset List

			Path	Packages
M			src/completion/kateargumenthinttree.cpp (2 lines)
M			src/completion/katecompletionmodel.cpp (13 lines)
M			src/completion/katecompletiontree.cpp (7 lines)
M			src/completion/katecompletionwidget.cpp (3 lines)
M			src/schema/katecolortreewidget.cpp (2 lines)