Differential D23930

Set XCB to required if building the X backend
ClosedPublic
Actions

Authored by davidedmundson on Sep 13 2019, 3:35 PM.

Details

Reviewers
zzag
Commits
R278:aaacf7d5c206: Set XCB to required if building the X backend
Summary

Otherwise builds could fail on missing dependencies at build time,
rather than configure time.

This was previously broken, but my extra dependency on XCB::Res made it
noticable.

Diff Detail

Repository
R278 KWindowSystem
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Sep 13 2019, 3:35 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 13 2019, 3:35 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Sep 13 2019, 3:35 PM
zzag accepted this revision.Sep 13 2019, 3:37 PM
This revision is now accepted and ready to land.Sep 13 2019, 3:37 PM
Closed by commit R278:aaacf7d5c206: Set XCB to required if building the X backend (authored by davidedmundson). · Explain WhySep 13 2019, 3:50 PM
This revision was automatically updated to reflect the committed changes.
winterz added a subscriber: winterz.Sep 13 2019, 3:52 PM

+1
will fix the problem I reported.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (2 lines)

Diff 66002

View Options

CMakeLists.txt

Loading...