| romangg |
| KWin |
Some of the documentation did not say what the purpose of the
respective class was, but rather gave a tautology.
For people new to the code base it helps to mention that
DPMS is power management.
That DataDevice is for copy-and-paste and drag-and-drop is
maybe obvious to people used to X11 API, but not very clear
to most others.
When first reading the KWayland code, some explanations
help getting around.
| Lint OK |
| No Unit Test Coverage |
| Buildable 16543 | |
| Build 16561: arc lint + arc unit |
| src/client/dpms.h | ||
|---|---|---|
| 44 | Yea, maybe just write that this class is meant to create the DPMS object below only. You already have the information you provided here there then. | |
| src/server/dpms_interface.h | ||
| 38–43 | Not sure why it should not be valid. Maybe add that the code interaction server-side happens only via the OutputInterface. Because client-side in KWayland the respective Dpms class provides the API. | |
Some of the documentation did not say what the purpose of the
respective class was, but rather gave a tautology.
For people new to the code base it helps to mention that
DPMS is power management.
That DataDevice is for copy...
| src/client/dpms.h | ||
|---|---|---|
| 44 | I agree. The first two lines are actually repetitions and they don't say what the class is good for at all. I'll update this. | |