Differential D23909

Pass area by const reference to placeFoo methods
ClosedPublic
Actions

Authored by zzag on Sep 12 2019, 3:38 PM.

Tags

Subscribers

romangg, gladhorn, kwin

Details

Reviewers

Group Reviewers

Diff Detail

Repository

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 16439
Build 16457: arc lint + arc unit

zzag created this revision.Sep 12 2019, 3:38 PM

Restricted Application added a project: KWin. · View Herald TranscriptSep 12 2019, 3:38 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Sep 12 2019, 3:38 PM

Harbormaster completed remote builds in B16439: Diff 65930.Sep 12 2019, 3:38 PM

gladhorn added a subscriber: gladhorn.Sep 14 2019, 8:28 PM

gladhorn added inline comments.

manage.cpp
408–409	This looks like it does more than the commit message says. Is it fixing something? Then it should maybe be an independent commit.

zzag added inline comments.Sep 14 2019, 8:32 PM

manage.cpp
408–409	Nope, I'm trying to preserve the old behavior. See placement.cpp:587.

gladhorn accepted this revision.Sep 17 2019, 7:30 AM

This revision is now accepted and ready to land.Sep 17 2019, 7:30 AM

zzag closed this revision.Sep 17 2019, 7:31 AM

Please next time besides a title add a meaningful description if you push a patch with more than a trivial change and without review. I assume it was just a mistake that you also didn't link back to the review in the commit bccbb8f3a5f8.

In D23909#533058, @romangg wrote:

Please next time besides a title add a meaningful description if you push a patch with more than a trivial change and without review. I assume it was just a mistake that you also didn't link back to the review in the commit bccbb8f3a5f8.

Yes, I forgot to arc amend that patch.

Revision Contents
Changeset List

			Path	Packages
M			abstract_client.cpp (2 lines)
M			manage.cpp (2 lines)
M			placement.h (18 lines)
M			placement.cpp (27 lines)
M			shell_client.h (3 lines)
M			shell_client.cpp (4 lines)
M			workspace.cpp (4 lines)

Diff 65930

abstract_client.cpp

Loading...

manage.cpp

Loading...

placement.h

Loading...

placement.cpp

Loading...

shell_client.h

Loading...

shell_client.cpp

Loading...

workspace.cpp

Loading...