[KUrlNavigatorButton] Fix QString usage to not use [] out of bounds.
ClosedPublic
Actions

Authored by dfaure on Sep 12 2019, 11:22 AM.

Details

Reviewers

elvisangelaccio

Commits

Summary

Since Qt-5.14 this leads to a runtime warning from QCharRef.

The solution resizes "big" before hand, and then resizes again at
the end, to the final size.

Test Plan

running dolphin; new unittest

Repository

R241 KIO

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16424
Build 16442: arc lint + arc unit

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

dfaure requested review of this revision.Sep 12 2019, 11:22 AM

I don't have 5.14 around atm, so I trust you've tested this :)

autotests/kurlnavigatortest.cpp
265	Did you mean `cwd` ?

This revision is now accepted and ready to land.Sep 12 2019, 12:19 PM

Clean up autotest code

In D23898#529947, @elvisangelaccio wrote:

I don't have 5.14 around atm, so I trust you've tested this :)

Well the only new thing in 5.14 is a runtime warning. This patch should work with older versions of Qt too :-)

Everything looks good and the new test passes for me.

			Path	Packages
M			autotests/kurlnavigatortest.h (1 line)
M			autotests/kurlnavigatortest.cpp (19 lines)
M			src/filewidgets/kurlnavigatorbutton.cpp (4 lines)
M			src/filewidgets/kurlnavigatorbutton_p.h (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	65903	57780c2		Sep 12 2019, 11:22 AM	★	★
Diff 2	65905	57780c2	Clean up autotest code	Sep 12 2019, 12:22 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
905613b0762e	8657cd9fb0c3	57780c20b00a	David Faure	[KUrlNavigatorButton] Fix QString usage to not use [] out of bounds. (Show More…)	Sep 12 2019, 12:21 PM