Port away from Qt's foreach: loop directly over pimpl member
ClosedPublic

Authored by kossebau on Wed, Sep 11, 12:09 AM.

Details

Summary

The old implementation of all the KActionCollection methods was a bit
inconsistent: some places loop directly over d->actions, while others do
it over the container copy created via call to the public getter method.
Without obvious reason for the different approach.

This patch ports the remaining foreach (and one ported before) to
a range-based for loop directly over the pimpl container object.

Diff Detail

Repository
R263 KXmlGui
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Wed, Sep 11, 12:09 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptWed, Sep 11, 12:09 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Wed, Sep 11, 12:09 AM
cullmann accepted this revision.Wed, Sep 11, 4:59 AM
cullmann added a subscriber: cullmann.

Looks more consistent.

This revision is now accepted and ready to land.Wed, Sep 11, 4:59 AM
This revision was automatically updated to reflect the committed changes.