Show connectivity status in tooltip
ClosedPublic

Authored by jgrulich on Sep 10 2019, 8:23 PM.

Details

Diff Detail

Repository
R116 Plasma Network Management Applet
Branch
tooltip-connectivity-status
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16355
Build 16373: arc lint + arc unit
jgrulich created this revision.Sep 10 2019, 8:23 PM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 10 2019, 8:23 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jgrulich requested review of this revision.Sep 10 2019, 8:23 PM

Don't you need to connect to connectivity change signal, too?

libs/declarative/networkstatus.cpp
227

I think this is bit too technical. Maybe something like "authentication required" or whatever we use in the captive portal notification is better wording

Don't you need to connect to connectivity change signal, too?

Ups, I probably want to.

jgrulich updated this revision to Diff 65807.Sep 10 2019, 9:22 PM
  • Address review comments
broulik accepted this revision.Sep 12 2019, 7:48 AM

Thanks!

This revision is now accepted and ready to land.Sep 12 2019, 7:48 AM
This revision was automatically updated to reflect the committed changes.