Show connectivity status in tooltip
ClosedPublic

Authored by jgrulich on Tue, Sep 10, 8:23 PM.

Details

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jgrulich created this revision.Tue, Sep 10, 8:23 PM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Sep 10, 8:23 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jgrulich requested review of this revision.Tue, Sep 10, 8:23 PM

Don't you need to connect to connectivity change signal, too?

libs/declarative/networkstatus.cpp
227

I think this is bit too technical. Maybe something like "authentication required" or whatever we use in the captive portal notification is better wording

Don't you need to connect to connectivity change signal, too?

Ups, I probably want to.

jgrulich updated this revision to Diff 65807.Tue, Sep 10, 9:22 PM
  • Address review comments
broulik accepted this revision.Thu, Sep 12, 7:48 AM

Thanks!

This revision is now accepted and ready to land.Thu, Sep 12, 7:48 AM
This revision was automatically updated to reflect the committed changes.