When in Desktop view, show a desktop-style toolbar with centered actions

Authored by ngraham on Sep 10 2019, 7:17 PM.



One thing that has bugged me about Kamoso forever is how it insists on looking like a
mobile app when run on the desktop. This seems to be to be contrary to Kirigami's
reason for existence and does not showcase the toolkit's excellent convergence

This patch resolves that by using the default auto-switching feature and therefore
displays a desktop-style toolbar when run on the desktop. To improve the appearance, it
makes use of a new optional feature in Kirigami added in D23845 to center the actions
when in desktop toolbar mode.

BUG: 402948
FIXED-IN: 19.12.0

Depends on D23845

Test Plan

Apply D23845 to Kirigami, then apply this to Kamoso and run the app.



When D23845 is not applied, the actions are right-aligned, but nothing bad happens, so I opted not to increase the required Frameworks version in the CMakeLists.txt file.

Diff Detail

R474 Kamoso
desktop-ui-on-the-desktop (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 16635
Build 16653: arc lint + arc unit
ngraham requested review of this revision.Sep 10 2019, 7:17 PM
ngraham created this revision.
ndavis accepted this revision.Sep 10 2019, 7:20 PM
This revision is now accepted and ready to land.Sep 10 2019, 7:20 PM
ngraham edited the summary of this revision. (Show Details)Sep 10 2019, 7:21 PM
ngraham edited the test plan for this revision. (Show Details)
ngraham updated this revision to Diff 65867.Sep 11 2019, 5:28 PM

Adapt to different API

ngraham updated this revision to Diff 65868.Sep 11 2019, 5:30 PM

Increase Frameworks dependency version since this new variant of the Kirigami API is no longer harmless to set in the app when the API isn't available yet

ngraham updated this revision to Diff 66233.Sep 16 2019, 3:23 PM

Don't bump the version in this patch (do it later after Frameworks 5.63 tagging)

ngraham closed this revision.Sep 16 2019, 3:25 PM