When in Desktop view, show a desktop-style toolbar with centered actions
AcceptedPublic

Authored by ngraham on Tue, Sep 10, 7:17 PM.

Details

Reviewers
apol
ndavis
Group Reviewers
VDG
Summary

One thing that has bugged me about Kamoso forever is how it insists on looking like a
mobile app when run on the desktop. This seems to be to be contrary to Kirigami's
reason for existence and does not showcase the toolkit's excellent convergence
features.

This patch resolves that by using the default auto-switching feature and therefore
displays a desktop-style toolbar when run on the desktop. To improve the appearance, it
makes use of a new optional feature in Kirigami added in D23845 to center the actions
when in desktop toolbar mode.

BUG: 402948
FIXED-IN: 19.12.0

Depends on D23845

Test Plan

Apply D23845 to Kirigami, then apply this to Kamoso and run the app.

Before:

After:

When D23845 is not applied, the actions are right-aligned, but nothing bad happens, so I opted not to increase the required Frameworks version in the CMakeLists.txt file.

Diff Detail

Repository
R474 Kamoso
Branch
desktop-ui-on-the-desktop (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16394
Build 16412: arc lint + arc unit
ngraham requested review of this revision.Tue, Sep 10, 7:17 PM
ngraham created this revision.
ndavis accepted this revision.Tue, Sep 10, 7:20 PM
This revision is now accepted and ready to land.Tue, Sep 10, 7:20 PM
ngraham edited the summary of this revision. (Show Details)Tue, Sep 10, 7:21 PM
ngraham edited the test plan for this revision. (Show Details)
ngraham updated this revision to Diff 65867.Wed, Sep 11, 5:28 PM

Adapt to different API

ngraham updated this revision to Diff 65868.Wed, Sep 11, 5:30 PM

Increase Frameworks dependency version since this new variant of the Kirigami API is no longer harmless to set in the app when the API isn't available yet