Differential D23833

Fix port to QJS
ClosedPublic
Actions

Authored by carewolf on Sep 10 2019, 1:34 PM.

Details

Reviewers
dfaure
Commits
R241:9e1220bf76ad: Fix port to QJS
Summary

Two mistakes with DateRange was discovered after I figured out
how to test it.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
carewolf created this revision.Sep 10 2019, 1:34 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 10 2019, 1:34 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
carewolf requested review of this revision.Sep 10 2019, 1:34 PM
dfaure accepted this revision.Sep 10 2019, 1:37 PM

Can you maybe document how to test this, e.g. in the README in this dir?

This revision is now accepted and ready to land.Sep 10 2019, 1:37 PM
carewolf added a comment.Sep 10 2019, 2:50 PM

It was already described in the two tests included kpactest.pac and kpactest2.pac

Closed by commit R241:9e1220bf76ad: Fix port to QJS (authored by carewolf). · Explain WhySep 10 2019, 2:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kpac/CMakeLists.txt (2 lines)
Msrc/kpac/script.cpp (14 lines)

Diff 65767

View Options

src/kpac/CMakeLists.txt

Loading...
View Options

src/kpac/script.cpp

Loading...