Differential D23825

Split KSslErrorUiData from KTcpSocket
ClosedPublic
Actions

Authored by vkrause on Sep 10 2019, 10:03 AM.

Details

Reviewers
dfaure
aacid
Commits
R241:79ee43be4d3f: Split KSslErrorUiData from KTcpSocket
Summary

The former we want to keep, the latter we want to deprecate, so this is
a necessary first step to detangle them.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Sep 10 2019, 10:03 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptSep 10 2019, 10:03 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Sep 10 2019, 10:03 AM
aacid added a subscriber: aacid.Sep 10 2019, 10:17 AM
aacid added inline comments.
src/core/ksslerroruidata.h
26 ↗(On Diff #65731)

Minor comment, with all the "noise" around QList in Qt6, would it be maybe more future proof to just #include <QList> ehre so we don't end up declaring a class that doesn't exist in the future?

aacid accepted this revision.Sep 10 2019, 10:17 AM

Other than that just commit it i'd say, you're just moving code around so no need to "re-review" code that we already accept as "good" for the moment imho

This revision is now accepted and ready to land.Sep 10 2019, 10:17 AM
Closed by commit R241:79ee43be4d3f: Split KSslErrorUiData from KTcpSocket (authored by vkrause). · Explain WhySep 10 2019, 3:21 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 7 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 65775

View Options

src/core/ksslerroruidata.h

Loading...
View Options

src/core/ktcpsocket_p.h

Loading...