Differential D23824

Initial start of variables dialog
ClosedPublic
Actions

Authored by dhaumann on Sep 10 2019, 10:02 AM.

Details

Reviewers

cullmann

Commits

R39:6b8b652979a2: Initial start of variables dialog

Summary

This patch adds one public function to KTextEditor::Editor:

void addVariableExpansion(const QVector<QWidget*>& widgets,
                          const QStringList& variables = QStringList()) const;

Once called for QLineEdits (QTextEdit support still pending),
QLineEdits will get an action that opens an variable expansion
dialog that allows the user to insert variables from a list
view.

What is still missing:

add support for QTextEdits
use for backup prefix/suffix (bug 403583)
use in External Tools plugin (bug 299248)

Test Plan

make && make test

Diff Detail

Repository

R39 KTextEditor

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dhaumann created this revision.Sep 10 2019, 10:02 AM

Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSep 10 2019, 10:02 AM

Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript

dhaumann requested review of this revision.Sep 10 2019, 10:02 AM

Harbormaster completed remote builds in B16310: Diff 65730.Sep 10 2019, 10:02 AM

:P ok

This revision is now accepted and ready to land.Sep 10 2019, 10:05 AM

Closed by commit R39:6b8b652979a2: Initial start of variables dialog (authored by dhaumann). · Explain WhySep 10 2019, 10:05 AM

This revision was automatically updated to reflect the committed changes.

Upsa, file missing :P

Revision Contents
Changeset List

		Path
M		src/CMakeLists.txt (3 lines)
M		src/include/ktexteditor/editor.h (19 lines)
M		src/utils/kateglobal.h (21 lines)
M		src/utils/kateglobal.cpp (124 lines)
D	M	src/utils/katemacroexpander.h (44 lines)
D	M	src/utils/katemacroexpander.cpp (73 lines)
A	M	src/utils/katevariableexpansionhelpers.h (101 lines)
A	M	src/utils/katevariableexpansionmanager.h (76 lines)
A	M	src/utils/katevariableexpansionmanager.cpp (273 lines)
M		src/utils/ktexteditor.cpp (65 lines)
M		src/utils/variable.h (27 lines)
M		src/utils/variable.cpp (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	65730	1c0b006		Sep 10 2019, 10:02 AM	★	★
Diff 2	65732	ed2752e	R39:6b8b652979a22fbe276d37fbac7c6178a5b9ad37	Sep 10 2019, 10:05 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
8e79d00bc344	518f9c2306b8	f07fa8bb1227	Dominik Haumann	Fix indentation	Sep 10 2019, 9:54 AM
f07fa8bb1227	587193e372d3	e764e461bf7e	Dominik Haumann	Add some KF6 TODOs for later cleanup	Sep 10 2019, 9:54 AM
e764e461bf7e	6274e6af7d66	db7916bbdd31	Dominik Haumann	Full support for QLineEdit	Sep 10 2019, 9:53 AM
db7916bbdd31	598b7dc63946	e4e8534f7da6	Dominik Haumann	Move varaible registration to variable expansion manager	Sep 8 2019, 3:14 PM
e4e8534f7da6	2c2dcd2f89bc	f0b665b66cf0	Dominik Haumann	Move variable expansion related code to KateVariableExpansionManager	Sep 8 2019, 3:02 PM
f0b665b66cf0	e3665c3a8d39	89d206b28dbc 1c0b0069b960	Dominik Haumann	Merge branch 'master' into add-variables-dialog	Sep 7 2019, 12:53 PM
89d206b28dbc	10c9f461c8df	46ef43c5c3e1	Dominik Haumann	Initial start of variables dialog	Aug 21 2019, 7:27 PM