Port away from foreach loops over members without calls to owner class
ClosedPublic

Authored by kossebau on Tue, Sep 10, 12:52 AM.

Details

Summary

There is some small risk here:

  • overseen call chains which still call the owner and modify the container
  • other threads might access the same containers, even if class is not designed to be thread-safe, but wrong usages are currently caught mostly by the container copy

GIT_SILENT

Diff Detail

Repository
R263 KXmlGui
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Tue, Sep 10, 12:52 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptTue, Sep 10, 12:52 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
kossebau requested review of this revision.Tue, Sep 10, 12:52 AM
dfaure accepted this revision.Tue, Sep 10, 5:28 PM
This revision is now accepted and ready to land.Tue, Sep 10, 5:28 PM
This revision was automatically updated to reflect the committed changes.