Port away from foreach loops over members without calls to owner class
ClosedPublic
Actions

Authored by kossebau on Sep 10 2019, 12:52 AM.

Details

Reviewers

dfaure

Commits

Summary

There is some small risk here:

overseen call chains which still call the owner and modify the container
other threads might access the same containers, even if class is not designed to be thread-safe, but wrong usages are currently caught mostly by the container copy

GIT_SILENT

Repository

R263 KXmlGui

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.Sep 10 2019, 12:52 AM

This revision is now accepted and ready to land.Sep 10 2019, 5:28 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/kactioncollection.cpp (16 lines)
M			src/kgesture.cpp (2 lines)
M			src/kkeysequencewidget.cpp (6 lines)
M			src/kshortcutsdialog.cpp (4 lines)
M			src/kshortcutseditor.cpp (6 lines)
M			src/ktoolbar.cpp (2 lines)
M			src/ktoolbarhandler.cpp (4 lines)
M			src/kxmlguiclient.cpp (8 lines)
M			src/kxmlguifactory.cpp (8 lines)
M			src/kxmlguifactory_p.cpp (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	65715	8673512		Sep 10 2019, 12:52 AM	★	★
Diff 2	65788	ae5a58d	R263:c0844ac2a6d67ecbe2bdc7d6388e7938b2918c8f	Sep 10 2019, 6:29 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
3e88358cc80a	cb31756bc8a5	867351258d1f	Friedrich W. H. Kossebau	Port away from foreach loops over members without calls to owner class (Show More…)	Sep 10 2019, 12:51 AM