[KImageFormats] Port HDR (Radiance RGBE) image loader to Qt5
ClosedPublic

Authored by cfeck on Tue, Sep 10, 12:31 AM.

Details

Test Plan

Tested with HDR images from hdrihaven.com

  • Loading in KolourPaint works
  • Thumbnails in Dolphin work

Diff Detail

Repository
R287 KImageFormats
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cfeck created this revision.Tue, Sep 10, 12:31 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptTue, Sep 10, 12:31 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
cfeck requested review of this revision.Tue, Sep 10, 12:31 AM
aacid added a subscriber: aacid.Tue, Sep 10, 7:59 AM

Could you try to figure out if adding some autotest file would be hard?

i think all is needed is an autotests/read/hdr folder with some hdr files and their png counterpart and then readtest will magically pick it up

cfeck updated this revision to Diff 65784.Tue, Sep 10, 4:51 PM

Add hdr to autotests

aacid accepted this revision.Fri, Sep 13, 9:48 AM

The test fails here because the autotests/read/hdr/rgb.png file is 0 bytes, but if that is a phabricator artifact and it's really not a 0 bytes size, go ahead and commit :)

This revision is now accepted and ready to land.Fri, Sep 13, 9:48 AM
This revision was automatically updated to reflect the committed changes.
cfeck added a comment.Sat, Sep 14, 1:31 PM

I somehow knew autotest would fail on FreeBSD ... I cannot investigate why it fails, maybe too old MIME database?