Remove some spacing on lockscreen that was causing elements to get cut off on small displays
AcceptedPublic

Authored by kishoreg on Sun, Sep 8, 10:53 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Summary

This patch removes some spacing which was making the 'switch users' button get slightly cut off on small displays (1366x768). Quite a few old laptops have screens of this size, so it is good to take into account that display size as well, as long as it doesn't negatively affect the appearance for large displays.

BUG: 410801

Before this patch:
Lockscreen on small display (1366x768):


Lockscreen on big display (1920x1080):

After this patch:
Lockscreen on small display (1366x768):


Lockscreen on big display (1920x1080):

Test Plan

Lock screen when connected to a low-res display and check that the 'switch users' button isn't cut off.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
kishoreg created this revision.Sun, Sep 8, 10:53 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSun, Sep 8, 10:53 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kishoreg requested review of this revision.Sun, Sep 8, 10:53 AM
kishoreg edited the summary of this revision. (Show Details)
ngraham accepted this revision.Mon, Sep 9, 3:57 PM
ngraham added a subscriber: ngraham.

LGTM. Any objections?

This revision is now accepted and ready to land.Mon, Sep 9, 3:57 PM
filipf added a subscriber: filipf.EditedMon, Sep 9, 4:18 PM

Yikes, we need to fix that.

So what this patch does is moves *all* of the UI up a bit.

One issue is you should then also definitely check and modify the Breeze SDDM theme so the two look identical.

But... you could maybe skip that and use an alternative approach here. We could reduce the spacing between the media player controls and the switch user button. I would be more in favor of that than shifting everything up, especially since I see it's a bit bigger than spacing between the avatar and the clock.

We could revisit vertical centering after that though.

kishoreg updated this revision to Diff 65896.Thu, Sep 12, 2:57 AM

@filipf Is this better?

Screenshot on small display (1366x768):

Screenshot on big display (1920x1080):