Remove some spacing on lockscreen that was causing elements to get cut off on small displays
ClosedPublic

Authored by kishoreg on Sep 8 2019, 10:53 AM.

Details

Summary

This patch removes some spacing which was making the 'switch users' button get slightly cut off on small displays (1366x768). Quite a few old laptops have screens of this size, so it is good to take into account that display size as well, as long as it doesn't negatively affect the appearance for large displays.

BUG: 410801
FIXED-IN: 5.17.0

Test Plan

Lock screen when connected to a low-res display and check that the 'switch users' button isn't cut off.

Before this patch:
Lockscreen on small display (1366x768):


Lockscreen on big display (1920x1080):

After this patch:
Lockscreen on small display (1366x768):


Lockscreen on big display (1920x1080):

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
kishoreg created this revision.Sep 8 2019, 10:53 AM
Restricted Application added a project: Plasma. · View Herald TranscriptSep 8 2019, 10:53 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kishoreg requested review of this revision.Sep 8 2019, 10:53 AM
kishoreg edited the summary of this revision. (Show Details)
ngraham accepted this revision.Sep 9 2019, 3:57 PM
ngraham added a subscriber: ngraham.

LGTM. Any objections?

This revision is now accepted and ready to land.Sep 9 2019, 3:57 PM
filipf added a subscriber: filipf.EditedSep 9 2019, 4:18 PM

Yikes, we need to fix that.

So what this patch does is moves *all* of the UI up a bit.

One issue is you should then also definitely check and modify the Breeze SDDM theme so the two look identical.

But... you could maybe skip that and use an alternative approach here. We could reduce the spacing between the media player controls and the switch user button. I would be more in favor of that than shifting everything up, especially since I see it's a bit bigger than spacing between the avatar and the clock.

We could revisit vertical centering after that though.

kishoreg updated this revision to Diff 65896.Sep 12 2019, 2:57 AM

@filipf Is this better?

Screenshot on small display (1366x768):

Screenshot on big display (1920x1080):

Is this fine, or should I revert to the previous diff I uploaded?

LGTM but can you rebase it on the Plasma/5.17 branch please?

kishoreg updated this revision to Diff 66601.Sep 22 2019, 3:39 AM

Rebase on Plasma/5.17 branch

ngraham accepted this revision.Sep 22 2019, 4:26 AM

Still LGTM. @filipf or anyone else in VDG or Plasma, are there any objections to this patch in its current form?

ngraham edited the summary of this revision. (Show Details)Sep 22 2019, 4:26 AM
ngraham edited the test plan for this revision. (Show Details)
ngraham edited the test plan for this revision. (Show Details)
kishoreg edited the test plan for this revision. (Show Details)Sep 22 2019, 4:29 AM

@kishoreg since you have a smaller display handy, does the same thing happen on the login screen? If so, can you also apply the same fix to it in this patch?

@ngraham There are no issues on the login screen. Everything fits fine there.

filipf accepted this revision.Sep 23 2019, 10:12 AM

Looks OK. I think it should be landed on the 5.17 branch since the bug it's solving is important. Weird that the login screen is fine, but I guess we can see if we need to tweak it later.

This revision was automatically updated to reflect the committed changes.