Details

Reviewers

broulik
graesslin

Group Reviewers

Plasma

Commits

R122:a5a325e20c15: Make powerdevil normal executable instead of kded module

Summary

This will allow kwin to grant permission to powerdevil which no other
application should have. Previously used kded module is now replaced by
the application which installs in LIBEXEC dir and started by desktop
file in /etc/xdg/autostart

Test Plan

Restarted session, powerdevil starts and all functions work perfectly

Diff Detail

Repository

R122 Powerdevil

Branch

powerdevil-executable (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

bshah updated this revision to Diff 5741.Aug 8 2016, 12:50 PM

bshah retitled this revision from to Make powerdevil normal executable instead of kded module.

bshah updated this object.

bshah edited the test plan for this revision. (Show Details)

bshah added reviewers: Plasma, broulik, graesslin.

Restricted Application added a project: Plasma. · View Herald TranscriptAug 8 2016, 12:50 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

bshah mentioned this in T2055: separate powerdevil from kded to allow kwin_wayland to grant it permissions that nobody else should have.Aug 8 2016, 12:51 PM

Something is wrong with this on wayland, I don't see battery and brightness applet and powerdevil executable seems to exit safely if I remove it.. Here is log of powerdevil executable https://ptpb.pw/9Jtd..

shumski added a subscriber: shumski.Aug 8 2016, 2:41 PM

shumski added inline comments.

daemon/CMakeLists.txt
135 ↗	(On Diff #5741)	PowerDevil isn't a Framework, so this var is wrong.
daemon/powerdevil.desktop.cmake
1 ↗	(On Diff #5741)	Maybe autostart for this should be limited to Plasma only?

Don't install in kf5 libexec dir
Autostart powerdevil only in KDE
Make PowerDevilApp QGuiApplication instead of QObject

I just realized that this breaks the shortcuts, and I need to migrate older shortcuts over.

read shortcuts from kded5 component, unfortunately its close to impossible to migrate shortcuts using kconf_update

davidedmundson added a subscriber: davidedmundson.Aug 9 2016, 8:50 AM

davidedmundson added inline comments.

daemon/powerdevilapp.cpp
137 ↗	(On Diff #5741)	Should it have KCrash::setFlags(AutoRestart) ?

fix powerdevil exiting on wayland

Make it autorestart on crash
Make it unique so there are not multiple powerdevil

set desktopSettingsAware to false

mark comments as done

broulik accepted this revision.Aug 9 2016, 12:50 PM

broulik edited edge metadata.

This revision is now accepted and ready to land.Aug 9 2016, 12:50 PM

Closed by commit R122:a5a325e20c15: Make powerdevil normal executable instead of kded module (authored by bshah). · Explain WhyAug 9 2016, 12:55 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		daemon/CMakeLists.txt (29 lines)
V		daemon/{kdedpowerdevil.h → powerdevilapp.h}
V		daemon/{kdedpowerdevil.cpp → powerdevilapp.cpp}
A	M	daemon/main.cpp (33 lines)
V		daemon/{powerdevil.desktop → powerdevil.desktop.cmake}
V		daemon/{powerdevil.desktop.cmake ← powerdevil.desktop} (8 lines)
V		daemon/{powerdevilapp.h ← kdedpowerdevil.h} (19 lines)
V		daemon/{powerdevilapp.cpp ← kdedpowerdevil.cpp} (26 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	5741	2e2faec		Aug 8 2016, 12:50 PM	★	★
Diff 2	5749	2e2faec	- Don't install in kf5 libexec dir	Aug 9 2016, 3:40 AM	★	★
Diff 3	5751	2e2faec	read shortcuts from kded5 component, unfortunately its close to impossible to migrate shortcuts using kconf_update	Aug 9 2016, 7:05 AM	★	★
Diff 4	5758	2e2faec	fix powerdevil exiting on wayland	Aug 9 2016, 9:17 AM	★	★
Diff 5	5759	2e2faec	- Make it autorestart on crash	Aug 9 2016, 9:34 AM	★	★
Diff 6	5763	2e2faec	set desktopSettingsAware to false	Aug 9 2016, 10:13 AM	★	★
Diff 7	5773	332b54a	rPOWERDEVILa5a325e20c1588913829f1bf3dd92bde48dd6801	Aug 9 2016, 12:55 PM	★	★

Make powerdevil normal executable instead of kded module
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 5749

daemon/CMakeLists.txt

daemon/kdedpowerdevil.h

daemon/kdedpowerdevil.cpp

daemon/main.cpp

daemon/powerdevil.desktop

daemon/powerdevil.desktop.cmake

daemon/powerdevilapp.h

daemon/powerdevilapp.cpp

Make powerdevil normal executable instead of kded moduleClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 5749

daemon/CMakeLists.txt

daemon/kdedpowerdevil.h

daemon/kdedpowerdevil.cpp

daemon/main.cpp

daemon/powerdevil.desktop

daemon/powerdevil.desktop.cmake

daemon/powerdevilapp.h

daemon/powerdevilapp.cpp

Make powerdevil normal executable instead of kded module
ClosedPublic
Actions

Revision Contents
Changeset List