Do not report guiding as started in PHD2::StartGuiding Event handler because it will start scheduled capture prematurely (before Settle is complete).
ClosedPublic

Authored by alexcherney on Sep 4 2019, 12:46 PM.

Details

Summary

I was shooting a large mosaic (64 panels) with 135mm lens guiding with PHD2 and Ekos and there was a problem where guiding would be reported as started before GuideSettle, resulting in lost guide star and other issues. I traced it down to StartGuiding event handler incorrectly emitting newStatus(GUIDE_GUIDING) which would immediately trigger the capture in scheduler. PHD2 will always send SettleDone and GUIDE_GUIDING should be set there to avoid that problem. I tested the change extensively using simulators and did not find any issues - all works as expected.

Test Plan

Run Ekos with phd2 and simulators. Schedule a capture and observe guide logs. The capture should start only after phd2 guiding settles

Diff Detail

Repository
R321 KStars
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alexcherney created this revision.Sep 4 2019, 12:46 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptSep 4 2019, 12:46 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
alexcherney requested review of this revision.Sep 4 2019, 12:46 PM
mutlaqja accepted this revision.Sep 4 2019, 1:08 PM
mutlaqja added a subscriber: mutlaqja.

Great work, thank you for catching this Alex!

This revision is now accepted and ready to land.Sep 4 2019, 1:08 PM
This revision was automatically updated to reflect the committed changes.

Excellent, thanks for this change!

alexcherney edited the test plan for this revision. (Show Details)Sep 4 2019, 1:46 PM