Do not report guiding as started in PHD2::StartGuiding Event handler because it will start scheduled capture prematurely (before Settle is complete).
Summary: I was shooting a large mosaic (64 panels) with 135mm lens guiding with PHD2 and Ekos and there was a problem where guiding would be reported as started before GuideSettle, resulting in lost guide star and other issues. I traced it down to StartGuiding event handler incorrectly emitting newStatus(GUIDE_GUIDING) which would immediately trigger the capture in scheduler. PHD2 will always send SettleDone and GUIDE_GUIDING should be set there to avoid that problem. I tested the change extensively using simulators and did not find any issues - all works as expected.
Reviewers: KStars, mutlaqja
Reviewed By: KStars, mutlaqja
Subscribers: mutlaqja, kde-edu
Tags: KDE Edu
Differential Revision: https://phabricator.kde.org/D23717