Add option to store download origin url in xattr
ClosedPublic
Actions

Authored by broulik on Sep 3 2019, 4:38 PM.

Details

Reviewers

fvogt
ognarb

Group Reviewers

Plasma
VDG

Commits

R856:4e6ed0ced910: Add option to store download origin url in xattr

Summary

This feature got removed all over the place (wget, browsers) for valid privacy reasons but I found it super useful, so add an off-by-default option to restore it. Downloads started from incognito tabs are ignored.

Test Plan

Diff Detail

Repository

R856 Plasma Browser Integration

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik created this revision.Sep 3 2019, 4:38 PM

Restricted Application added a project: Plasma. · View Herald TranscriptSep 3 2019, 4:38 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik requested review of this revision.Sep 3 2019, 4:38 PM

Personally I find it useful too, so +1.

LGTM, but maybe move into a separate method instead? There's already too much in DownloadJob::update...

This revision is now accepted and ready to land.Sep 3 2019, 4:49 PM

Move into separate method

fvogt accepted this revision.Sep 3 2019, 6:00 PM

Closed by commit R856:4e6ed0ced910: Add option to store download origin url in xattr (authored by broulik). · Explain WhySep 3 2019, 6:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (1 line)
M			extension/_locales/en/messages.json (7 lines)
M			extension/constants.js (3 lines)
M			extension/extension-downloads.js (2 lines)
M			extension/options.html (6 lines)
M			host/CMakeLists.txt (1 line)
M			host/downloadjob.h (4 lines)
M			host/downloadjob.cpp (33 lines)
M			host/downloadplugin.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	65337			Sep 3 2019, 4:36 PM	★	★
Diff 2	65349			Sep 3 2019, 5:53 PM	★	★
Diff 3	65350	8478185	R856:4e6ed0ced910daf63d377d3ee51e970efcfe380c	Sep 3 2019, 6:05 PM	★	★