| dfaure |
| Frameworks |
In copyNextFile() if all files have been skipped QList::erase() will
return end() iterator, accessing the element it denotes will cause
a segmentation fault. Make sure the iterator is valid if it's changed
inside the while loop, if we're going to use it before control reaches
the loop condition.
Add a unit test.
BUG: 408350
FIXED-IN: 5.62.0
kioclient5 copy SOME_DIR_WITH_FILES DEST
kioclient5 copy --interactive SOME_DIR_WITH_FILES DEST
All unit tests passed (except kiocore-kacltest, but that's unrelated).
| No Linters Available |
| No Unit Test Coverage |
| Buildable 16156 | |
| Build 16174: arc lint + arc unit |
Thanks for the fix!
Do you feel like writing a unittest for it?
JobTest::chmodFileError shows how to use PredefinedAnswerJobUiDelegate to simulate the user pressing "Skip" in the dialog.
Write the test without your fix applied, so that you are sure it triggers the crash, before re-applying the fix.
| src/core/copyjob.cpp | ||
|---|---|---|
| 1640 | This comment only needs to be in the unittest, not in the code. If every bugfix leads to two lines of comments, the code becomes unreadable. | |