Differential D23698

document: Port away from foreach loops over members without calls to owner
ClosedPublic
Actions

Authored by kossebau on Sep 3 2019, 1:38 PM.

Details

Reviewers
cullmann
Group Reviewers
Kate
Commits
R39:84bb5661927b: document: Port away from foreach loops over members without calls to owner
Summary

There is some small risk here:

  • overseen call chains which still call the owner and modify the container
  • other threads might access the same containers, even if class is not designed to be thread-safe, but wrong usages are currently caught mostly by the container copy

GIT_SILENT

Diff Detail

Repository
R39 KTextEditor
Branch
portawayfromforeachforitemconstructionestimation_document
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 16050
Build 16068: arc lint + arc unit
kossebau created this revision.Sep 3 2019, 1:38 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSep 3 2019, 1:38 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
kossebau requested review of this revision.Sep 3 2019, 1:38 PM
cullmann accepted this revision.Sep 5 2019, 4:24 PM
cullmann added a subscriber: cullmann.

Looks ok.

This revision is now accepted and ready to land.Sep 5 2019, 4:24 PM
Closed by commit R39:84bb5661927b: document: Port away from foreach loops over members without calls to owner (authored by kossebau). · Explain WhySep 8 2019, 12:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/document/katedocument.cpp (13 lines)

Diff 65315

View Options

src/document/katedocument.cpp

Loading...