Differential D23689

Port away from Qt's foreach all loops over rvalue container objects
ClosedPublic
Actions

Authored by kossebau on Sep 3 2019, 8:52 AM.

Details

Reviewers

dhaumann

Group Reviewers

Kate

Commits

R39:baea21ac638f: Port away from Qt's foreach all loops over rvalue container objects

Summary

The other simple part of foreach porting, as those containers objects
are not shared with anyone, so the removal of the container copying has
no risks.

Diff Detail

Repository

R39 KTextEditor

Branch

moreplainforeachport

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 16035
Build 16053: arc lint + arc unit

kossebau created this revision.Sep 3 2019, 8:52 AM

Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptSep 3 2019, 8:52 AM

Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript

kossebau requested review of this revision.Sep 3 2019, 8:52 AM

Harbormaster completed remote builds in B16035: Diff 65292.Sep 3 2019, 8:52 AM

Lgtm

This revision is now accepted and ready to land.Sep 3 2019, 11:40 AM

Closed by commit R39:baea21ac638f: Port away from Qt's foreach all loops over rvalue container objects (authored by kossebau). · Explain WhySep 3 2019, 1:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/src/vimode/emulatedcommandbar.cpp (4 lines)
M			src/completion/katecompletionwidget.cpp (3 lines)
M			src/dialogs/katedialogs.cpp (6 lines)
M			src/document/katedocument.cpp (6 lines)
M			src/mode/katemodemanager.cpp (3 lines)
M			src/printing/printconfigwidgets.cpp (3 lines)
M			src/render/katerenderer.cpp (3 lines)
M			src/schema/kateschema.cpp (6 lines)
M			src/script/katescriptmanager.cpp (6 lines)
M			src/spellcheck/ontheflycheck.cpp (21 lines)
M			src/utils/kateautoindent.cpp (3 lines)
M			src/utils/kateconfig.cpp (6 lines)
M			src/utils/katetemplatehandler.cpp (3 lines)
M			src/variableeditor/variablelineedit.cpp (4 lines)
M			src/view/katemessagewidget.cpp (6 lines)
M			src/view/kateview.cpp (6 lines)
M			src/view/kateviewhelpers.cpp (3 lines)
M			src/vimode/appcommands.cpp (15 lines)
M			src/vimode/keymapper.cpp (4 lines)
M			src/vimode/mappings.cpp (5 lines)
M			src/vimode/modes/modebase.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	65292	6f29e94		Sep 3 2019, 8:52 AM	★	★
Diff 2	65311	6f29e94	R39:baea21ac638fd29188a00008fea66ff8b2f2aaa9	Sep 3 2019, 1:09 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
b92e98d5aa6b	3e8e60b20744	6f29e9483c8c	Friedrich W. H. Kossebau	Port away from Qt's foreach all loops over rvalue container objects (Show More…)	Sep 3 2019, 8:51 AM