Also indent dependent settings.
Details
Details
- Reviewers
davidedmundson fvogt ognarb - Group Reviewers
Plasma - Commits
- R856:8478185257ff: Allow a setting to declaratively depend on another one
- Enhanced media controls is indented now
- Checking and unchecking media controls enables/disables enhanced media controls (like before, but now without "special code")
Diff Detail
Diff Detail
- Repository
- R856 Plasma Browser Integration
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
- Be explicit about the value, so you can also have something on when something else is *un*checked
- Initially check dependencies, too, not just when changing setting
Comment Actions
Works. I don't think the CSS indentation style works for data-depends-settings-value="FALSE" though, that would just be weird.
Comment Actions
The visuals are completely independent (just a CSS class) from the actual logic of turning it on/off (the data attributes)