Differential D23664

Port away from Qt's foreach all loops over method-local containers
ClosedPublic
Actions

Authored by kossebau on Sep 2 2019, 9:38 AM.

Tags

Subscribers

kde-frameworks-devel

Details

Reviewers

Commits

R263:867351258d1f: Port away from Qt's foreach all loops over method-local containers

Summary

The simple part of foreach porting, as those containers objects are not
shared with anyone, so the removal of the container copying has no risks.

GIT_SILENT

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau created this revision.Sep 2 2019, 9:38 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptSep 2 2019, 9:38 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

kossebau requested review of this revision.Sep 2 2019, 9:38 AM

Harbormaster completed remote builds in B15991: Diff 65213.Sep 2 2019, 9:38 AM

kossebau edited the summary of this revision. (Show Details)Sep 2 2019, 1:03 PM

Ping :)

dfaure accepted this revision.Sep 9 2019, 10:07 PM

This revision is now accepted and ready to land.Sep 9 2019, 10:07 PM

Closed by commit R263:867351258d1f: Port away from Qt's foreach all loops over method-local containers (authored by kossebau). · Explain WhySep 9 2019, 10:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/kxmlgui_unittest.cpp (4 lines)
M			src/kedittoolbar.cpp (4 lines)
M			src/kkeysequencewidget.cpp (4 lines)
M			src/kmainwindow.cpp (2 lines)
M			src/kmainwindowiface.cpp (4 lines)
M			src/kshortcutschemeseditor.cpp (2 lines)
M			src/kshortcutseditor.cpp (4 lines)
M			src/kswitchlanguagedialog_p.cpp (2 lines)
M			src/ktoolbar.cpp (6 lines)
M			src/ktoolbarhandler.cpp (4 lines)
M			src/kxmlguifactory.cpp (2 lines)
M			src/kxmlguiversionhandler.cpp (2 lines)

Diff 65709

autotests/kxmlgui_unittest.cpp

Loading...

src/kedittoolbar.cpp

Loading...

src/kkeysequencewidget.cpp

Loading...

src/kmainwindow.cpp

Loading...

src/kmainwindowiface.cpp

Loading...

src/kshortcutschemeseditor.cpp

Loading...

src/kshortcutseditor.cpp

Loading...

src/kswitchlanguagedialog_p.cpp

Loading...

src/ktoolbar.cpp

Loading...

src/ktoolbarhandler.cpp

Loading...

src/kxmlguifactory.cpp

Loading...

src/kxmlguiversionhandler.cpp

Loading...